Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] fix VLAN not supported docs #1742

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomastigera
Copy link
Contributor

@tomastigera tomastigera commented Oct 28, 2024

Product Version(s):

Issue:

fixes projectcalico/calico#9401

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit bbb72b7
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/671fd301abc9aa0008db3961
😎 Deploy Preview https://deploy-preview-1742--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🟢 up 15 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit bbb72b7
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/671fd30153c4d50008bd09b1
😎 Deploy Preview https://deploy-preview-1742--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 75 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -74,7 +74,7 @@ To enable IPv6 in eBPF mode, see [Configure dual stack or IPv6 only](../../netwo
- Floating IPs.
- SCTP (either for policy or services). This is due to lack of kernel support for the SCTP checksum in BPF.
- `Log` action in policy rules. This is because the `Log` action maps to the iptables `LOG` action and BPF programs cannot access that log.
- VLAN-based traffic.
- VLAN-based traffic - it is OK to use a VLAN device as a device that connects a node to the cluster, modify `bpfDataIfacePattern` accordingly. However any VLAN packets on the "main - non-vlan" device would be dropped if the main interfaces is included in `bpfDataIfacePattern`. Include `bond0.1010` and exclude `bond0`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[1] Seems this changes it to a limitation, no? eBPF supports VLAN-based traffic, but only in the following circumstances: etc.
[2] How does this relate to a no-support statement we have elsewhere for "Tagged VLAN devices"? (see here)
[3] I don't understand the details in this addition. Best I can figure, you can't generally use VLAN, but if you configure it right (with bpfDataIfacePattern) you can have a particular node connect to the cluster with a VLAN device. I don't get the bit about main non-vlan or the bond stuff. Are those workarounds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[1] - idk if it is just a limitation or whether that is how you always need to set it up
[2] it is the same change for other places, but but I want to hash out a version first
[3] yes you need to configure it, wan't work out of the box. I think that is the limitation, but @sridhartigera is working on it. The bond stuff is not a workaround, that is how it should work.https://docs.google.com/document/d/1RNHRR39TNl0LXYt5tad14lI72ZFl3g5mDzmhQ3Qe6CM/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calico eBPF mode: support VLAN-based traffic
2 participants