Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli erros in rsplit.R Fixes #512 #518

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

JamesHWade
Copy link
Contributor

No description provided.

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I left two comments directly on the code and have one high-level one: We already import cli_abort() so there is no need to namespace it as cli::cli_abort().

R/rsplit.R Outdated Show resolved Hide resolved
R/rsplit.R Outdated Show resolved Hide resolved
This was referenced Aug 15, 2024
@hfrick hfrick merged commit 90b2a87 into tidymodels:main Aug 15, 2024
12 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants