Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses cli_abort in R/caret.R #517

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Uses cli_abort in R/caret.R #517

merged 5 commits into from
Sep 12, 2024

Conversation

Dpananos
Copy link
Contributor

@Dpananos Dpananos commented Aug 15, 2024

closes #505

@Dpananos
Copy link
Contributor Author

Need to format with {.arg} as mentioned here #518 (comment)

@EmilHvitfeldt EmilHvitfeldt changed the title Uses cli_abbort in R/caret.R Uses cli_abort in R/caret.R Aug 15, 2024
@Dpananos
Copy link
Contributor Author

This should be ready for review

@hfrick
Copy link
Member

hfrick commented Aug 23, 2024

@Dpananos Thanks a bunch for the multiple PRs! I'm just dropping in quickly to say that I'm OOO until the week after next but will get to this after my return.

@hfrick hfrick merged commit e489196 into tidymodels:main Sep 12, 2024
12 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cli errors for R/caret.R
2 participants