Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs: General DocSite improvements. #400

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Aug 30, 2023

Associated with #392, but will not close until also completed in edk2-pytool-extensions.

  • Changes the theme to material instead of readthedocs as there are no longer any plans to post this to readthedocs.

  • Utilizes new features in mkdocs-awesome-pages to allow for a hierarchical sidebar for the API references rather than a flattened list of API references.

  • Adds light / dark mode to the docs

  • Adds navigation tabs in the header for the main links.

Sidebar changes

Before

image

After

image
image
image

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f98a8e6) 81.26% compared to head (8d39bad) 81.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files          57       57           
  Lines        7404     7404           
=======================================
  Hits         6017     6017           
  Misses       1387     1387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes self-assigned this Aug 30, 2023
@Javagedes Javagedes added this to the v0.18.1 milestone Sep 20, 2023
@Javagedes Javagedes modified the milestones: v0.18.1, 0.18.3 Oct 2, 2023
@Javagedes Javagedes modified the milestones: 0.19.1, 0.19.2, 0.19.3, 0.19.4 Oct 23, 2023
@Javagedes Javagedes modified the milestones: 0.19.4, 0.19.5 Nov 1, 2023
@Javagedes Javagedes modified the milestones: 0.19.5, 0.19.6, v0.19.7 Nov 20, 2023
@Javagedes Javagedes modified the milestones: 0.19.7, 0.19.8 Dec 4, 2023
@Javagedes Javagedes modified the milestones: 0.19.8, v0.19.9 Dec 13, 2023
@makubacki
Copy link
Member

Saw Sean's approval come through, missed it earlier. The hierarchical view and dark/light mode support are nice enhancements.

@Javagedes Javagedes modified the milestones: v0.19.9, v0.19.10 Jan 11, 2024
- Changes the theme to material instead of readthedocs as there are no
  longer any plans to post this to readthedocs.

- Utilizes new features in mkdocs-awesome-pages to allow for a
  hierarchical sidebar for the API references rather than a flattened
  list of API references.
@Javagedes Javagedes merged commit 0476b8a into tianocore:master Jan 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants