Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: require function annotations #370

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Jul 17, 2023

Adds the rule ANN which requires function annotations. See https://beta.ruff.rs/docs/rules/#flake8-annotations-ann for more information.

Only adds type annotations to function headers so this will have no effect on the codebase itself.

closes #208

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9c78d80) 81.18% compared to head (5726ada) 81.26%.

Files Patch % Lines
edk2toollib/utility_functions.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   81.18%   81.26%   +0.08%     
==========================================
  Files          57       57              
  Lines        7372     7404      +32     
==========================================
+ Hits         5985     6017      +32     
  Misses       1387     1387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes added this to the v0.19.10 milestone Jan 11, 2024
@Javagedes Javagedes merged commit f98a8e6 into tianocore:master Jan 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Type Hinting
2 participants