locate_tools: Search all VS installations for vcvarsall.bat #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new function, FindAllWithVsWhere which functions the same as FindWithVsWhere, but returns a list of all paths found, rather than the first path only. Updates QueryVcVariables to use FindAllWithVsWhere, and loops through each path found, attempting to locate the vcvarsall.bat file. It will use the first one found; if none are found, it will print an error and raise an exception.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
- Coverage 81.20% 81.18% -0.02%
==========================================
Files 57 57
Lines 7363 7372 +9
==========================================
+ Hits 5979 5985 +6
- Misses 1384 1387 +3 ☔ View full report in Codecov by Sentry. |
…und. FindAllWithVsWhere will return the list sorted from newest to oldest
spbrogan
approved these changes
Jan 11, 2024
makubacki
reviewed
Jan 11, 2024
makubacki
approved these changes
Jan 11, 2024
gguo11837463
approved these changes
Jan 11, 2024
I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function, FindAllWithVsWhere which functions the same as FindWithVsWhere, but returns a list of all paths found, rather than the first path only.
Updates QueryVcVariables to use FindAllWithVsWhere, and loops through each path found, attempting to locate the vcvarsall.bat file. It will use the first one found; if none are found, it will print an error and raise an exception.
Testing
Installed multiple instances of VS tools and verified FindAllWithVsWhere produces paths for both. Removed vcvarsall.bat from one installation and verified that it was found in the second installation. Then removed vcvarsall.bat from both installations and verified the error message printed as expected.
Closes #486