MinPlatformPkg: Isolate FSP dependency for PlatformInitPreMem #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaddyDengKC
requested review from
ChaselChiu,
nate-desimone and
SaiChaganty
as code owners
|
Hi @nate-desimone and @ChaselChiu, please kindly review this PR and provide your comment, thanks. |
ChaselChiu
approved these changes
Oct 21, 2024
|
will merge the PR as no other feedback from the teams. |
5 tasks
|
@ChaselChiu, I'm surprised these were merged without file headers/copyrights in some of the newly added files. Was that intentionally allowed? |
No, I overlooked. We need file header for sure. @PaddyDengKC , @MarcChen46 , could you help to add file headers for new files? |
PaddyDengKC
added a commit
to PaddyDengKC/edk2-platforms
that referenced
this pull request
Oct 29, 2024
Merged
|
Hi @ChaselChiu , I created #236 to add the requested changes to them. Please help to review them, thanks. |
ChaselChiu
pushed a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a PlatformInitPreMemNonFsp that non Intel platforms can consume it to use PlatformInitPreMem without adding Intel specific packages as dependency.