Make PlatformInitPreMem independent to IntelSiliconPkg and IntelFsp2WrapperPkg #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
|
@microsoft-github-policy-service agree company="Microsoft" |
|
Hi @makubacki @Javagedes @os-d @apop5, Could you please help to review this PR? Regards, |
makubacki
reviewed
Sep 9, 2024
PaddyDengKC
force-pushed
the
user/v-paddydeng/IndepPlatformInitPreMem
branch
from
0f1c877 to
2302a3e
Compare
PlatformInitPreMemNonFsp provides identical function compares to PlatformInitPreMem. But using FspSupportNull.c thus does not require IntelSiliconPkg and IntelFsp2WrapperPkg as dependency.
PaddyDengKC
force-pushed
the
user/v-paddydeng/IndepPlatformInitPreMem
branch
from
2302a3e to
fdc6284
Compare
PaddyDengKC
force-pushed
the
user/v-paddydeng/IndepPlatformInitPreMem
branch
from
3bab8f4 to
99ab205
Compare
|
Hi @makubacki , I modified the PR based on tianocore/edk2-platforms#224 Regards, |
makubacki
reviewed
Oct 28, 2024
makubacki
reviewed
Oct 28, 2024
makubacki
reviewed
Oct 28, 2024
makubacki
reviewed
Oct 28, 2024
makubacki
reviewed
Oct 28, 2024
|
@PaddyDengKC, there are a few things that the upstream maintainers missed that should be fixed. Please make an upstream change with those fixes and then amend this PR with them.
|
|
Hi @makubacki , I pushed a commit to update as you suggested. Regards, |
Thanks Paddy |
makubacki
reviewed
Oct 31, 2024
MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Oct 31, 2024
MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
Outdated
Show resolved
Hide resolved
makubacki
approved these changes
Oct 31, 2024
apop5
approved these changes
Oct 31, 2024
Co-authored-by: Michael Kubacki <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]>
|
Pipelines failed due to a temporary issue with a submodule missing that has been resolved in the latest Mu Basecore. Restarted the pipeline runes. |
makubacki
added a commit
to makubacki/mu_common_intel_min_platform
that referenced
this pull request
Nov 5, 2024
…rapperPkg (microsoft#293) ## Description This driver is shared across different Silicon vendors. So it should not use any Intel specific packages. In order to achieve this, added a new lib `FspSupportLib` to isolate silicon related PCDs - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested CI build passed. ## Integration Instructions No additional change is required for the consuming platforms. --------- Co-authored-by: Michael Kubacki <[email protected]>
5 tasks
makubacki
added a commit
that referenced
this pull request
Nov 5, 2024
…rapperPkg (#293) ## Description This driver is shared across different Silicon vendors. So it should not use any Intel specific packages. In order to achieve this, added a new lib `FspSupportLib` to isolate silicon related PCDs - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested CI build passed. ## Integration Instructions No additional change is required for the consuming platforms. --------- Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This driver is shared across different Silicon vendors. So it should not use any Intel specific packages.
In order to achieve this, added a new lib
FspSupportLibto isolate silicon related PCDsflow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
CI build passed.
Integration Instructions
No additional change is required for the consuming platforms.