-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to filter posts containing keyword in title/body #974
Conversation
@micahmo ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature!
One thing I noticed while testing... This might be a problem I introduced with my dialog refactor, but I was able to add an empty string as a filter by pressing enter on the keyboard. (I think this is a problem with the comment search too.)
Ahh, I missed that edge case while testing it. I can add in an additional check to make sure we can't add in empty strings (and also trim whitespaces while I'm at it) |
Added trimming to |
Nice! We can try to add something similar to comment search at some point. |
Pull Request Description
This PR enables the ability to add and remove keywords. When adding keywords, any post that contains the keyword in the title or body will be filtered out from the feed page (and any widget that uses the feed page).
Some additional notes:
width: min(MediaQuery.of(context).size.width, 700)
toshowThunderDialog
'sAlertDialog
. This allows alert dialogs to take up more of the width of the screen similar to the input dialogs (community, user, instance, etc)UserSettingsPage
since it now appears on the Settings page, I've adjusted some of the UI for blocking users/communities/instances to match the other UIs present in the Settings page.Issue Being Fixed
Issue Number: #513
Screenshots / Recordings
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-12.at.11.41.12.mp4
Checklist
semanticLabel
s where applicable for accessibility?