Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword filter #513

Closed
Benjamin-R-Balzer opened this issue Jul 31, 2023 · 12 comments
Closed

Keyword filter #513

Benjamin-R-Balzer opened this issue Jul 31, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version

Comments

@Benjamin-R-Balzer
Copy link

Please, correct me if I'm missing out somehow, but I've searched high & low for a simple keyword filter section in Settings, etc., and I'm comin' up empty.

All due respect, but I feel that this is a standard component of all aggregate reader apps (eg. Sync, Boost, RIF, etc.), and I'm genuinely surprised to see it missing in Thunder. I'm unaware of how simple it may be to implement, so please take this as a polite request, not a judgement.

The app itself is fantastic, otherwise, and I'm pretty impressed at the feature additions with each update. Keep up the great work!

@Benjamin-R-Balzer Benjamin-R-Balzer added the enhancement New feature or request label Jul 31, 2023
@hjiangsu
Copy link
Member

hjiangsu commented Aug 1, 2023

I also agree that this should be a feature, but we just have not gotten around to it!

Could you maybe provide some more details in how you would like to see this be implemented? Would this be for posts, comments, or something else entirely? I think showing screenshots of other apps and how they do it, or providing some context into how you would like to access/edit these keywords would be really beneficial

@Benjamin-R-Balzer
Copy link
Author

Benjamin-R-Balzer commented Aug 1, 2023 via email

@hjiangsu
Copy link
Member

hjiangsu commented Aug 1, 2023

Thanks for the reply! Another question: for other apps, does this filter only apply to the title of the post? or does it also apply to the body/text of the post?

It also sounds like to me that there's a way to bypass the filtered keywords as well. Would this be a setting to toggle on/off filters, or is there another way to trigger this bypass?

@Benjamin-R-Balzer
Copy link
Author

Benjamin-R-Balzer commented Aug 2, 2023 via email

@zchilds
Copy link

zchilds commented Aug 2, 2023

Hey there, chiming in to how Memmy currently handles filters. At the moment there are two options.

  1. Filtering posts based on words in the title of the post
  2. Filtering out posts based on the instance they were posted from

Works really well and I'd love to see something like that implemented in Thunder. Thanks!

@hjiangsu
Copy link
Member

hjiangsu commented Aug 2, 2023

Filtering posts based on words in the title of the post

This should definitely be possible to do!

Filtering out posts based on the instance they were posted from

For this particular issue, I do feel like it should be a feature that lemmy itself provides as any solutions that we implement on our end will still be sub-optimal (would still need to perform the same API calls and it would still eat up data whereas the lemmy instance would be able to directly filter that out before sending the response back to us)

I'm hoping that lemmy will implement a native way to do this before we get around to this, but if it doesn't end up happening, then we can see how best to do this on our end

@zchilds
Copy link

zchilds commented Aug 2, 2023

Lemmy natively does provide the option to block communities, but it does not currently allow people to filter posts based on title. I actually submitted an issue on the Lemmy side as well.

LemmyNet/lemmy#3710

image

@hjiangsu
Copy link
Member

hjiangsu commented Aug 2, 2023

Lemmy natively does provide the option to block communities, but it does not currently allow people to filter posts based on title. I actually submitted an issue on the Lemmy side as well.

Yeah, we have functionality to block communities and users since that's offered by lemmy natively. It would be great if they could also add in filtering for keywords on posts/instances since that would just make everything more efficient in terms of reducing fetching unnecessary data

@Benjamin-R-Balzer
Copy link
Author

Benjamin-R-Balzer commented Aug 2, 2023 via email

@donnielrt
Copy link

Just as an FYI, seems like instance blocking will land in lemmy soon: LemmyNet/lemmy#3869

@hjiangsu hjiangsu added the P1 High-priority issues at the top of the work list label Sep 15, 2023
@hjiangsu hjiangsu self-assigned this Dec 12, 2023
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Dec 12, 2023
@hjiangsu
Copy link
Member

This is now in PR stage, let me know what you think about the implementation! (video is attached in the PR: #974)

@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on P1 High-priority issues at the top of the work list labels Jan 19, 2024
@hjiangsu
Copy link
Member

Keyword filters were added in a previous version and is generally available! I'll close this issue as completed. If there are any other requests, feel free to create a new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

4 participants