Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile popup fix for HA 2023.7.3 #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raymercury
Copy link

#606 #617
Around 2023.7.3 mobile popups got really longgggg.
Happens for iOS, android, and web browser.

fix

@ve1koz111
Copy link

This is not working for me @raymercury. I edited /config/custom_components/browser_mod/browser_mod.js with the correct code as listed by the changes on github and this has had no effect on my popup bug.

Let me know if I'm doing this wrong.
Thanks

@raymercury
Copy link
Author

@ve1koz111 I think modifying the existing JS file doesn't work. You may need to install a modified version of browser_mod integration using HACS.

Use HACS to install a test version which includes the fix:
Uninstall current instance of browser_mod, clicking "ignore".
Add my fork of browser_mod as a custom repository and install it, then reboot HA.

@shlomki
Copy link

shlomki commented Sep 2, 2023

@raymercury Thanks so much for fixing this bug, it was driving me bonkers!

@ogoncalves200874
Copy link

@raymercury Thanks so much!

@andyblac
Copy link

andyblac commented Oct 3, 2023

@thomasloven can we get this PR merged ?

@cikaybe
Copy link

cikaybe commented Oct 27, 2023

Uninstalled in HACS, uninstalled in Devices and services. Installed your repository, and after restart installed in devices and services.
Still with the size issue.
Maybe i'm doing something wrong. Can you help me @raymercury ?

@ciddi89
Copy link

ciddi89 commented Jan 24, 2024

Fix is working great. Is it possible to merge it please?

@psi-4ward
Copy link

👍

@csszokolai
Copy link

@thomasloven could you please merge this pr to solve our problem? Thank you!

@thomasloven
Copy link
Owner

This would make the popup look different from native Home Assistant popups, like the more-info dialog.

@Spegeli
Copy link

Spegeli commented Aug 2, 2024

This would make the popup look different from native Home Assistant popups, like the more-info dialog.

Yeah but thats what some ppl want instead of a popup card which use 100% height ^^ maybe you can add it with a Option in the Settings so people can decide which style they want? Full-Screen or the Smaller one

@Soukyuu
Copy link

Soukyuu commented Aug 2, 2024

@thomasloven: I see what you mean, but all I want is browser_mod to respect its own size/style options, as mentioned in #639 The default might as well stay as it is.

@yosilevy
Copy link
Contributor

yosilevy commented Sep 5, 2024

@thomasloven I think this is needed. I did it manually for now otherwise my wife rejected my latest home changes... She's a tough reviewer...

@ASNNetworks
Copy link

This is not working for me @raymercury. I edited /config/custom_components/browser_mod/browser_mod.js with the correct code as listed by the changes on github and this has had no effect on my popup bug.

Let me know if I'm doing this wrong. Thanks

Hi, replying here hoping you see this. Would it be possible for you to update your fork of browser_mod as well, so it works with HA 2024.7+? Your mobille fix sadly is stuck on an older browser_mod version, which has broken popups with 2024.7+. So in order to use popups again, I have to use the official browser_mod, which doesn't have the mobile fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.