Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Close Popup in mobile browser #708

Open
3 tasks done
400HPMustang opened this issue May 21, 2024 · 1 comment
Open
3 tasks done

Cannot Close Popup in mobile browser #708

400HPMustang opened this issue May 21, 2024 · 1 comment

Comments

@400HPMustang
Copy link

My Home Assistant version: 2024.5.3

What I am doing:

Trigger a popup using browser_mod.popup on Safari on iOS

What I expected to happen:

To be able to click an area outside the popup so that it will close

What happened instead:
The popup opens full screen and there is no space outside the popup to click so that it will close

Minimal steps to reproduce:
Create custom button card with the popup below that has enough entites so that you have to scroll on a mobile browser
Trigger popup on mobile browser
Popup opens full screen and cannot be closed

# The least amount of code or steps possible to reproduce my error
service: browser_mod.popup
target: {}
data:
  dismissable: true
  content:
    type: custom:auto-entities
    show_empty: false
    card:
      type: entities
      title: Lights on
      show_header_toggle: false
    filter:
      include:
        - domain: light
        - domain: switch
      exclude:
        - state: "off"
        - state: unavailable
        - hidden_by: user
        - integration: adaptive_lighting
        - integration: bhyve
        - integration: unifi
        - integration: sonos
        - name: Fountain
        - name: /[Pp]ower/
        - name: /[Pp]ump/
        - name: /[Ww]ax/
        - name: /[Mm]ode/
        - name: /[Bb]ridge/

# Put your code/steps here

Error messages from the browser console:

// Select everything from the browser console and copy it

// Paste it here

IMG_2409

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

  • Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).

  • Have made sure I am using the latest version of the plugin.

  • [X ] Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.

  • Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

@Spegeli
Copy link

Spegeli commented Jul 7, 2024

Look at that fix request:

#619

Instead of Tap on empty space, the back-swipe should Close the Pop-up too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants