Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update few Feature #84

Closed
wants to merge 1 commit into from
Closed

update few Feature #84

wants to merge 1 commit into from

Conversation

ehlxr
Copy link

@ehlxr ehlxr commented Jan 24, 2018 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): N/A

What is the new behavior?

  • Update picture display
  • add gitalk support
  • update sidebar author image display

How to use?

In NexT _config.yml:

gitalk:
  enable: true
  click_show: false # if true,need to click to show
  owner: # MUST HAVE, Your Github Username
  repo: # MUST HAVE, The name of the repo you use to store gitalk comments
  client_id: # MUST HAVE, Github client id for the gitalk
  client_secret: # EITHER this or proxy_gateway, Github access secret token for the gitalk
  admin: # MUST HAVE, Your Github Username

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ehlxr ehlxr changed the title update update few Feature Jan 24, 2018
@ehlxr
Copy link
Author

ehlxr commented Jan 24, 2018

Update picture display
add gitalk support
update sidebar author image display

@wafer-li
Copy link
Member

What do you mean update?

Show some demo or screenshots of it.

And for the gitalk, add something like the #58 (comment) described. Or we will not approve it.

sli1989
sli1989 reviewed Jan 24, 2018
View reviewed changes
layout/_layout.swig
@@ -93,5 +93,25 @@
{% include '_third-party/scroll-cookie.swig' %}
{% include '_third-party/exturl.swig' %}
{% include '_third-party/bookmark.swig' %}

<script type="text/javascript">
var OriginTitile=document.title;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personalized too much...😅

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivan-nginx Can we consider adding this feature (change to a different title when window is no longer in focus) to the list #67 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ApolloZhu @ivan-nginx https://github.com/theme-next/hexo-next-title

@ehlxr
Copy link
Author

ehlxr commented Jan 24, 2018

demo page http://ehlxr.me

@wafer-li
Copy link
Member

And I want to denote that:

image

The gitalk need read and write permission for ALL my public repos.

If you modify some gitalk script, and all my public repo will be ruin.

To get out of the posibile problem, I personally strongly deprecated gitalk and gitment and something like them.

But I DO like the other feature you provide, like the click to show disqus, maybe we could extract it from this PR.

@ivan-nginx
Copy link
Member

ivan-nginx commented Jan 24, 2018 •
edited
Loading

Please, don't need to add commits with mixins features. Separate features and divide it on different commits/pulls is the best choise to close all questions.

Also, pull on GiTalk was added in #58.

@ehlxr
Copy link
Author

ehlxr commented Jan 24, 2018

ok, i will reorganize the pr

@ehlxr ehlxr closed this Jan 24, 2018
@ivan-nginx ivan-nginx mentioned this pull request Jan 25, 2018
Closed
72 tasks
@maple3142 maple3142 mentioned this pull request Nov 4, 2018
Merged
15 tasks
@1v9 1v9 mentioned this pull request Jun 22, 2019
Closed
stevenjoezhang
stevenjoezhang reviewed Oct 1, 2019
View reviewed changes
layout/_macro/post.swig
@@ -1,6 +1,6 @@
{% macro render(post, is_index, post_extra_class) %}

{% set headlessPost = Array.prototype.indexOf.call(['quote', 'picture'], post.type) > -1 %}
{% set headlessPost = Array.prototype.indexOf.call(['quote', 'picture', 'nohead'], post.type) > -1 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header: false option added in 92fdf86#diff-0e030eb6dd7b9d25bfcba06bc8ea5609R27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx left review comments

@stevenjoezhang stevenjoezhang stevenjoezhang left review comments

@ApolloZhu ApolloZhu ApolloZhu left review comments

@sli1989 sli1989 sli1989 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ehlxr @wafer-li @ivan-nginx @sli1989 @ApolloZhu @stevenjoezhang