Add gitalk comment system #464
Conversation
|
The file |
|
Both gitalk and md5.js should be able to configure cdn by _config.yml |
| <script type="text/javascript" src="{{ theme.gitalk.gitalk_cdn_prefix }}gitalk.min.js"></script> | ||
| <script type="text/javascript" src="{{ theme.gitalk.md5_cdn }}"></script> | ||
|
|
||
| {% set gitalk_js_url = "//cdn.bootcss.com/gitalk/1.4.0/gitalk.min.js" %} |
There was a problem hiding this comment.
According to #105, it will be better to use jsDelivr as default cdn.
_config.yml
Outdated
| @@ -1009,6 +1021,19 @@ vendors: | |||
| # Example: https://cdn.jsdelivr.net/npm/[email protected]/dist/Valine.min.js | |||
| valine: | |||
|
|
|||
| # Internal version: | |||
There was a problem hiding this comment.
Is there any reason not to include a internal version of gitalk?
There was a problem hiding this comment.
Yes, i think need to include internal version.
There was a problem hiding this comment.
Fixed, both gitalk and md5 cdn source from jsDelivr now.
|
Then, what's the next step? |
* add gitalk comment system * update cdn for gitalk * update vendors config and fix typos * remove local md5.js * update cdn source * Revert "update cdn source" This reverts commit 8175b46. * update cdn source * update md5 cdn
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): N/A
What is the new behavior?
Description about this pull, in several words...
Add Gitalk comment system according to blogs following:
Demo as Gitalk official site
How to use?
1. Create new Github Application
Create a new Github application at Register a new OAuth application, remember what you inputed, and then you will get
Client IDandClient Secretused later.2. Enable Gitalk
Enable
gitalkin NexT_config.yml, putClient IDandClient Secretdown here:Does this PR introduce a breaking change?