-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added Gitalk support. #2037
Conversation
@AlynxZhou as i see, this looks like on Github? But this is save comments like Gitment, right? If yes, i think need to add config on this right into Gitmint/Gitment for reverse compatibility. |
In fact this is a different comment system, just works like gitment, but I
am afraid it cannot use config in gitment because they are diffierent
projects, they have diffierent code and people use one won't use another, I
think, because seems no one tested can one read another's issue as its
comments, just let them two choice.
…On Dec 17, 2017 12:15, "Ivan.Nginx" ***@***.***> wrote:
@AlynxZhou <https://github.com/alynxzhou> as i see, this looks like on
Github? But this is save comments like Gitment, right? If yes, i think need
to add config on this right into Gitmint/Gitment for reverse compatibility.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2037 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIDaxz8vkUq_GJCrYFTfm7s00eeFEfWDks5tBJVjgaJpZM4REigv>
.
|
And in fact just css and js styles have different, right? So, i think about migrate this styles to Gitmint/Gitment and peoples can choice what style they want: standart Gitment style, or this, modernize style. That's what i'm talking about. For now this have modern style but use standart imsun's Gitment gateway, and i don't appreciate it (see my comment about this here). I understand what it's pretty beautifull Gitment patch, but what users will do if they GitHUB account's will be breaking down? Who will answer for this doings if thousand peoples will talk something like: i installed NexT theme and turn on cool comments system, but my Github accound was stolen then. This is just example, think about it. We can to do hardfork of this styles, just a variant. OR We can try to ask author to adapt he's styles for our mint/ment system in NexT, and this will be best decision. |
OK, I am back to my dorm and have read a lot words about it because I know little, firstly I add gitalk just because original gitment is inactive for a long time, and don't know things about gitmint and client secret, finally I think I understand what you mean. |
That's right. |
Hi @ivan-nginx , will you merge this pull request? |
ok |
Already added in NexT 6 here: theme-next/hexo-theme-next#464 NexT is rebased into organization repo. You also may read this for details. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A similiar pull request has been created but due to some reasons didn't pass.
Issue Number(s): N/A
What is the new behavior?
Description about this pull, in several words...
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?