Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated notifications call in rail #613

Open
wants to merge 1 commit into
base: foreman_3_7
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/views/layouts/foreman_rh_cloud/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<% end %>

<% content_for(:content) do %>
<%= notifications %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we can remove the whole file as we moved to full react-router pages,
imo this file doesn't even get called, what do you think @ShimShtein ?

<div id="organization-id" data-id="<%= Organization.current.id if Organization.current %>" ></div>
<div id="user-id" data-id="<%= User.current.id if User.current %>" ></div>
<%= yield %>
Expand Down