Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated notifications call in rail #613

Open
wants to merge 1 commit into
base: foreman_3_7
Choose a base branch
from

Conversation

MariaAga
Copy link
Member

@ShimShtein
Copy link
Member

Thanks @MariaAga! I will merge this one once we branch Foreman 3.0 version

@@ -3,7 +3,6 @@
<% end %>

<% content_for(:content) do %>
<%= notifications %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we can remove the whole file as we moved to full react-router pages,
imo this file doesn't even get called, what do you think @ShimShtein ?

@ekohl
Copy link
Member

ekohl commented Nov 27, 2023

Thanks @MariaAga! I will merge this one once we branch Foreman 3.0 version

That was a long time ago. What's the status on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants