Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Ubuntu Noble #410

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Add CI for Ubuntu Noble #410

merged 5 commits into from
Jul 16, 2024

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Jul 11, 2024

No description provided.

@Levi-Armstrong
Copy link
Contributor

It looks like the Noble build is failing because of clang-tidy errors, @rjoomen How do you think we should address this? Currently in Tesseract we run clang-tidy separately to avoid this issue.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 11, 2024

Not clang-tidy, I think, but gcc, because of the warnings-as-errors option. Or is it the ros-industrial-cmake-boilerplate that runs clang-tidy during a normal build?

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 11, 2024

I can take a shot at fixing all the warnings, as I'm using clangd in VSCode that's fairly easy.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 12, 2024

See #411.

@Levi-Armstrong
Copy link
Contributor

@rjoomen The MR was merged but there are still errors during the build.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 15, 2024

Can you merge this, so my next shot at fixing the clang-tidy errors will run the CI I'm trying to pass (I can't merge, because required CI checks do not pass and I do not have enough rights to merge anyway)?

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 15, 2024

See #412.

@Levi-Armstrong
Copy link
Contributor

@rjoomen Still a few clang-tidy errors in trajopt_common/src/utils.cpp.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 16, 2024

See #414.

@Levi-Armstrong Levi-Armstrong merged commit 5a80a73 into master Jul 16, 2024
11 of 13 checks passed
@Levi-Armstrong Levi-Armstrong deleted the nobleci branch July 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants