Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Ubuntu Noble #467

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Jul 11, 2024

No description provided.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 14, 2024

This now fails because tesseract_planning has not been updated to match this yet: tesseract-robotics/tesseract@0de0151

@Levi-Armstrong
Copy link
Contributor

This depends on the trajopt MR so the docker is available.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 17, 2024

noble-unstable fails, because:

E: The repository 'https://ppa.launchpadcontent.net/levi-armstrong/tesseract-robotics/ubuntu noble Release' does not have a Release file.

This ppa is not necessary on Noble though, as Taskflow (3.6.0) and qt-advanced-docking-system (3.8.3) are available on Noble.

@Levi-Armstrong can you add a release file for Noble to the ppa (without packages), so the error does not occur, or do we need to modify the CI to not use the ppa at all for Noble? And if so, how?

@Levi-Armstrong
Copy link
Contributor

They are needed and I will work on getting them published.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 17, 2024

They are needed and I will work on getting them published.

Why are they needed on Noble if they are available as system packages?

@Levi-Armstrong
Copy link
Contributor

Oh, I missed that. If they are available on the system then you should be able to use those.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 17, 2024

Oh, I missed that. If they are available on the system then you should be able to use those.

Indeed, I do. So the point is that the CI should not fail on your ppa not having an entry for Noble. It does not need to have the packages themselves, only a release file or something. Or if that is not possible, we'd need to disable the ppa for Noble.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 17, 2024

Indeed, I do. So the point is that the CI should not fail on your ppa not having an entry for Noble. It does not need to have the packages themselves, only a release file or something. Or if that is not possible, we'd need to disable the ppa for Noble.

I have to correct myself: that won't work, as Taskflow is taskflow in your ppa, but libtaskflow-cpp-dev in Noble, and qt-advanced-docking-system vs libqt-advanced-docking-system-dev. How can we modify .github/workflows/unstable.yml to support both focal+jammy with the ppa and noble without, but with different package names?

@Levi-Armstrong
Copy link
Contributor

Replace the this with the following. I may not have the if syntax correct but should be possible.

- name: Install Depends
        shell: bash
        run: |
          apt update
          apt upgrade -y
          apt install -y wget software-properties-common
          add-apt-repository ppa:levi-armstrong/tesseract-robotics
          apt install -y libompl-dev taskflow
- name: Install Depends
        if: matrix.distro != 'noble'
        shell: bash
        run: |
          apt update
          apt upgrade -y
          apt install -y wget software-properties-common
          add-apt-repository ppa:levi-armstrong/tesseract-robotics
          apt install -y libompl-dev taskflow

- name: Install Depends
        if: matrix.distro == 'noble'
        shell: bash
        run: |
          apt update
          apt upgrade -y
          apt install -y libompl-dev libtaskflow-cpp-dev

@rjoomen rjoomen force-pushed the nobleci branch 13 times, most recently from eda955e to 7d0fc3b Compare July 18, 2024 11:23
@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 18, 2024

I have no idea why rosdep fails to detect the installation of google-perftools in Docker/noble. It works fine for me locally in Noble.

@rjoomen rjoomen mentioned this pull request Jul 18, 2024
@rjoomen rjoomen requested review from Levi-Armstrong and marip8 July 18, 2024 11:46
@Levi-Armstrong
Copy link
Contributor

@rjoomen Are you planning to fix the clang-tidy errors; if not I recommend leaving the CI for clang-tidy to the one that was passing and create a ticket to updated clang-tidy.

@rjoomen
Copy link
Contributor Author

rjoomen commented Jul 18, 2024

@rjoomen Are you planning to fix the clang-tidy errors; if not I recommend leaving the CI for clang-tidy to the one that was passing and create a ticket to updated clang-tidy.

That's probably a better idea. I reverted the change.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (d2563f7) to head (8428db1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files         229      229           
  Lines       15711    15711           
=======================================
  Hits        13327    13327           
  Misses       2384     2384           

@Levi-Armstrong Levi-Armstrong merged commit 22354c6 into tesseract-robotics:master Jul 18, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants