Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unsupported external DTD and schema properties #931

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Handle unsupported external DTD and schema properties #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions shogun-gs-interceptor/src/main/java/de/terrestris/shogun/interceptor/util/OgcXmlUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,21 @@ public static Document getDocumentFromString(String xml) throws IOException {
InputSource source = new InputSource(new StringReader(xml));
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();

// limit resolution of external entities, see https://rules.sonarsource.com/c/type/Vulnerability/RSPEC-2755
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, "");
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");
try {
// limit resolution of external entities, see https://rules.sonarsource.com/c/type/Vulnerability/RSPEC-2755
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, "");
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");
} catch (IllegalArgumentException e) {
log.error("External DTD/Schema access properties not supported:"
+ e.getMessage());
}

DocumentBuilder builder = factory.newDocumentBuilder();
document = builder.parse(source);
} catch (ParserConfigurationException | SAXException | IOException e) {
throw new IOException("Could not parse input body " +
"as XML: " + e.getMessage());
} catch (IllegalArgumentException | ParserConfigurationException
| SAXException | IOException e) {
throw new IOException("Could not parse input body as XML: "
+ e.getMessage());
}
return document;
}
Expand Down
Loading