Handle unsupported external DTD and schema properties #931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR addresses an issue where the
DocumentBuilderFactory
would throw anIllegalArgumentException
when trying to setXMLConstants.ACCESS_EXTERNAL_DTD
andXMLConstants.ACCESS_EXTERNAL_SCHEMA
properties if the underlying XML parser does not support them.Now, the setting of external DTD and schema access properties is wrapped in a try-catch block to handle unsupported cases gracefully. The current implementation was causing a crash when the parser did not recognize the properties related to external DTD and schema access.
@terrestris/devs please review
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn test
locally).