-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for symmetry in initialB10ComponentVol calc #2017
Draft
bsculac
wants to merge
11
commits into
main
Choose a base branch
from
symmetry_parameter_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8074ee1 - Browse repository at this point
Copy the full SHA 8074ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d3d3fe - Browse repository at this point
Copy the full SHA 2d3d3feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40b76d1 - Browse repository at this point
Copy the full SHA 40b76d1View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c0b696 - Browse repository at this point
Copy the full SHA 7c0b696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d72657 - Browse repository at this point
Copy the full SHA 3d72657View commit details -
remove superfluous symmetry adjustment
The core.add method uses assembly.moveTo to place assemblies in the reactor. Since moveTo now accounts for changes in symmetry factor, having an additional adjustment in the core.add method is incorrect and would double account for any change in symmetry factor.
Configuration menu - View commit details
-
Copy full SHA for 1d9e807 - Browse repository at this point
Copy the full SHA 1d9e807View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85bdd01 - Browse repository at this point
Copy the full SHA 85bdd01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b34542e - Browse repository at this point
Copy the full SHA b34542eView commit details
Commits on Nov 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be19b2a - Browse repository at this point
Copy the full SHA be19b2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f7206d - Browse repository at this point
Copy the full SHA 7f7206dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8777b4d - Browse repository at this point
Copy the full SHA 8777b4dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.