account for symmetry in initialB10ComponentVol calc #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on running a test case to demonstrate that the parameters are correctly accounted for in assemblies that are split between symmetric portions of the core. |
The core.add method uses assembly.moveTo to place assemblies in the reactor. Since moveTo now accounts for changes in symmetry factor, having an additional adjustment in the core.add method is incorrect and would double account for any change in symmetry factor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
The block parameters
initialB10ComponentVolume,massHmBOL, andmolesHmBOLdid not have a location tag that would cause them to be multiplied by the symmetry factor when expanding to full core, so the VOLUME_INTEGRATED tag was added. This should cause these values to be correctly accounted for when assemblies are placed on symmetry boundaries.Why is the change being made?
Incorrect values were calculated for
initialB10ComponentVolumeand downstream values dependent on it for assemblies located in the center of 1/3rd symmetric cores.Checklist
docfolder.pyproject.toml.