-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run all tests if changing test folders itself #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The int test blocking this PR is failing on the |
/gcbrun |
/gcbrun |
glasnt
changed the title
debug: Run all tests if changing test folders itself
fix: Run all tests if changing test folders itself
Jan 16, 2024
Closed
The updates to this PR show the limitations in the current CI limitation technique: This PR is currently running the following tests:
|
Changes in #602 implemented some of these. Will re-create this PR after re-assessment. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/309966756
Proof of concept: When a PR comes in that edits testing infra itself, then all tests should be run to verify the change.
This PR adds an escape hatch to return successfully from the "prune unchanged directories" step without pruning anything, in the event we are changing something to do with tests themselves.
Initial list of folders: build, test, .github (changes in any of these folders will cause all tests to run)
Additionally: adds the
_RUN_ALL_TEST
check (define as a substitution variable on Cloud Build triggers, for example) to escape the escape sequence, and don't even check about pruning, just run all the tests.Note: given current infra, unsure if this change itself will allow tests to run.
Additional: In case of failures like #518 where
git
commands fail within the step, addset -e
as to exit immediately on error (otherwise last exit code for step is used to confirm success of step). Resolves #518Checklist
Readiness