CICD Bugs

[msampathkumar]

TL;DR

PTAL #510 (comment)

CICD is failing for unrelated errors.

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

NA

Terraform Version

NA

Additional information

No response

[rogerthatdev]

The root of the problem is this error that occurs on the first step of the build config:

fatal: ambiguous argument 'origin/': unknown revision or path not in the working tree.

This is due to this line in the yaml config that uses git diff origin/${_BASE_BRANCH} --name-only > _changed_files to make a list of files that the PR updates.

The problem seems to be that for some PRs such as this one that are coming from a fork, _BASE_BRANCH does not evaluate to main.

[rogerthatdev]

I'll add that it's possible for tests to pass instead of fail with this issue because the tests continue as if there are no files changed in the PR (example where the test passes but it does not run the changed terraform)

In the meantime, it will be important to verify that the int tests are passing for the impacted samples of each PR reviewed.

[glasnt]

re: enforcing failure: Cloud Build steps that finish with an exit code != 0 fail the entire build, but not when it happens within the step itself (like bash). Adding a set -e will exit the step with failure on first failure (as long as the fatal in git returns the appropriate exit code), causing the whole build to fail.

re: missing substitution variable: I'll investigate further.

[glasnt]

Reproduction in https://github.com/glasnt/cloud-build-context/pull/3/checks?check_run_id=20515490284

_BASE_BRANCH had value in the fork, but in case it didn't, adding the set -e should ensure failures actually fail out the build.

Updated #528 to add -e

[glasnt]

@msampathkumar #608 should resolve this issue, ptal