Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: BigLake Iceberg Table Examples #474

Closed
wants to merge 21 commits into from

Conversation

nevzheng
Copy link
Contributor

@nevzheng nevzheng commented Aug 15, 2023

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@nevzheng
Copy link
Contributor Author

nevzheng commented Aug 16, 2023

I've mailed GoogleCloudPlatform/cloud-foundation-toolkit#1776 to fix

@nevzheng
Copy link
Contributor Author

This CL is dependent on the connection API which I added in go/tf-samples/pull/470, which should be merged prior to re-running this build.



# This queries the provider for project information.
data "google_project" "project" {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tflint is failing because this has been declared but not referenced

@nevzheng nevzheng closed this Jan 16, 2024
@nevzheng
Copy link
Contributor Author

I'm focusing on other priorities at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants