fix: exclude parquet files from checks #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevzheng
requested review from
bharathkkb,
g-awmalik and
apeabody
as code owners
|
/gcbrun |
11 tasks
apeabody
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks for the contribution @nevzheng!
To be safe given all the formatting, we should also bump the dev-tools patch version (e.g. 1.14.4) https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/build/Makefile#L56
apeabody
reviewed
Aug 16, 2023
| fi | ||
| # load default ruleset | ||
| tflintCfg="/root/tflint/.tflint.example.hcl" | ||
| # if module, load tighter ruleset | ||
| if [[ $path == "." || $path == "./modules"* ]];then |
There was a problem hiding this comment.
I think this might need to move up a level?
|
moving to attempt 2 github.com//pull/1776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am drafting a PR to update terraform samples in terraform-google-modules/terraform-docs-samples#474
The lint stage of the CI is failing as we're attempting to check that parquet files end in new lines. You can't append new lines to parquet files wihtout invalidating them.
So we should not check that parquet files end in newlines.
Related PR: (#1725)