Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support defining tags per subnet name #1139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Support defining tags per subnet name #1139

wants to merge 2 commits into from

Commits on Nov 19, 2024

  1. feat: Support defining tags per subnet name 

    This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.

Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.
```terraform
  private_subnet_names = ["Private Subnet One", "Private Subnet Two"]
  private_subnet_tags_per_name = {
    "Private Subnet One" = {
      "subnet one" = "true"
    },
    "Private Subnet Two" = {
      "subnet two" = "true"
    }
  }
```
    @fatmcgav
    fatmcgav committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a37a21d View commit details
    Browse the repository at this point in the history

  2. Fix terraform-docs format 

    Needed to upgraded to latest `0.19.0` version locally...
    @fatmcgav
    fatmcgav committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bc75244 View commit details
    Browse the repository at this point in the history