Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support defining tags per subnet name #1139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fatmcgav
Copy link

@fatmcgav fatmcgav commented Nov 19, 2024

Description

This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.

Motivation and context

Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.

  private_subnet_names = ["Private Subnet One", "Private Subnet Two"]
  private_subnet_tags_per_name = {
    "Private Subnet One" = {
      "subnet one" = "true"
    },
    "Private Subnet Two" = {
      "subnet two" = "true"
    }
  }

Fixes #1129

This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.

Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.
```terraform
  private_subnet_names = ["Private Subnet One", "Private Subnet Two"]
  private_subnet_tags_per_name = {
    "Private Subnet One" = {
      "subnet one" = "true"
    },
    "Private Subnet Two" = {
      "subnet two" = "true"
    }
  }
```
@fatmcgav
Copy link
Author

Doh, that'll teach me to not check open PR's first... #1131 does essentially the same thing...

Needed to upgraded to latest `0.19.0` version locally...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Specific Tags On Subnets
1 participant