No ARCH_NAME in CI building umd_device #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
abhullar-tt,
pjanevskiTT,
blozano-tt and
vmilosevic
pjanevskiTT
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
It would be nice to update README accordingly along with these PRs that removed ARCH_NAME from the build. There is already an open issue about updating README - #83, but I think we should at least have build steps up to date
This was
linked to
issues
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation to #87 , to reflect the current state in our CI.
Related to #86 and a part of #51 .
There is now enough difference between building umd_device and umd_tests to warrant separate files, since umd_tests still requires ARCH_NAME and umd_device does not. This way it looks clearer.