Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on adding CI to umd repo #45

Closed
broskoTT opened this issue Sep 6, 2024 · 5 comments · Fixed by #70, #71, #74, #87 or #88
Closed

Work on adding CI to umd repo #45

broskoTT opened this issue Sep 6, 2024 · 5 comments · Fixed by #70, #71, #74, #87 or #88
Assignees
Labels
testing infrastructure Any kind of work which helps with testing or writing tests

Comments

@broskoTT
Copy link
Contributor

broskoTT commented Sep 6, 2024

Nothing to add for know, it should be pretty clear. Guard the UMD with tests

@broskoTT broskoTT added the enhancement New feature or request label Sep 6, 2024
@vtangTT
Copy link
Contributor

vtangTT commented Sep 9, 2024

Just FYI, as a stopgap solution for metal, we are running most/all UMD tests on the metal CI. They run for every push to main and every post-commit

https://github.com/tenstorrent/tt-metal/actions/workflows/umd-unit-tests-wrapper.yaml

@broskoTT broskoTT self-assigned this Sep 10, 2024
@broskoTT broskoTT added testing infrastructure Any kind of work which helps with testing or writing tests and removed enhancement New feature or request labels Sep 10, 2024
@broskoTT
Copy link
Contributor Author

Every push to tt-metal main, or umd main?
In any case we should have a CI here if we plan to ship this as a separate component/endpoint to our products.

@vtangTT
Copy link
Contributor

vtangTT commented Sep 10, 2024

Every push to tt-metal main will run post-commit which includes umd tests. Example run from most recent main:

https://github.com/tenstorrent/tt-metal/actions/runs/10794191678/job/29937907086

But I agree, I think the CI should ultimately be in this repo.

@broskoTT
Copy link
Contributor Author

That seems unnecessary, since not every commit on tt-metal will update the UMD commit used. Sounds like you're running same tests on the same version of umd?
Also, this doesn't offer any guarantees for UMDs progress, i.e. this doesn't guarantee the current tip of the branch is functional.

@vtangTT
Copy link
Contributor

vtangTT commented Sep 10, 2024

Yes, I agree it's not the best solution and like you said it only guarantees umd is not broken for the version metal points to.

It was mainly implemented to have some sort of verification for UMD (since at that time we aren't able to get CI machines onto the UMD repo). Also on the off chance that metal exposes an edge-case bug in umd.

It also allowed us to dispatch umd tests on CI through this pipeline: https://github.com/tenstorrent/tt-metal/actions/workflows/umd-unit-tests-wrapper.yaml

The tests themselves run fast enough such that they don't affect the total runtime of post-commit. If development is ramping up on UMD, CI should def be present in this repo, but temporarily it's possible to validate through metal CI if needed.

broskoTT added a commit that referenced this issue Sep 26, 2024
Related to #45 
tt-metal uses clang compiler.
This configuration was copied from metal's CMakeLists.txt.
The irds that we're using for tt-metal already have this setup, so it
shouldn't disrupt anyone.
I've already installed clang-17 in #70, so CI will still work with this
switch.
@broskoTT broskoTT linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment