-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tt_SiliconDevice to tt::umd::Cluster #265
Conversation
Can you elaborate a bit on this? Simulation & Mockup both inherit Do you think there is value in |
@joelsmithTT For the second part we can change it if we chose to implement those tests. It does make sense, we should consider it. In any case, according to the diagram, the Cluster class will be publicly facing class, which will have ClusterInternal holding implementation (the pimpl design pattern). The ClusterInternal would be a good candidate for this. |
dcf36e9
to
ded6eb5
Compare
328c653
to
28d2cd0
Compare
### Ticket Related to #13948 ### What's changed Related UMD PR: tenstorrent/tt-umd#265 Changed naming tt_device.h -> cluster.h tt_SiliconDriver -> tt::umd::Cluster ### Checklist - [x] Post commit CI passes: https://github.com/tenstorrent/tt-metal/actions/runs/11846636922 - [x] Blackhole Post commit (if applicable): https://github.com/tenstorrent/tt-metal/actions/runs/11839014934 - [x] Model regression CI testing passes (if applicable) - [x] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes
Fixes #108
For bigger picture, see https://docs.google.com/drawings/d/1-m1azdsBqMA0A6ATYRMfkhyeuOJuGCEI62N5a96LXj0/edit
Changes:
Note that tt_device will be removed, according to the diagram. Currently, simulation device and mockup device are specializations of current tt::umd::Cluster. When we create tt::umd::Chip abstraction, they will be moved correspondingly, and this tt_device abstraction will be removed.
API Changes
This PR has API changes: