Change tt_SiliconDevice to tt::umd::Cluster #14752
Merged
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
yan-zaretskiy,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
abhullar-tt
approved these changes
Nov 5, 2024
2 tasks
broskoTT
force-pushed
the
brosko/change_name_to_cluster
branch
from
53ab536
to
28d1e69
Compare
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Nov 14, 2024
Fixes #108 For bigger picture, see https://docs.google.com/drawings/d/1-m1azdsBqMA0A6ATYRMfkhyeuOJuGCEI62N5a96LXj0/edit Changes: - Renamed tt_SiliconDevice to Cluster - Added Cluster to tt::umd namespace. - Renamed tt_device.h to cluster.h, and tt_silicon_driver.cpp to cluster.cpp - Moved a few trivial functions from tt_device.cpp to cluster.cpp. Note that tt_device will be removed, according to the diagram. Currently, simulation device and mockup device are specializations of current tt::umd::Cluster. When we create tt::umd::Chip abstraction, they will be moved correspondingly, and this tt_device abstraction will be removed. ### API Changes This PR has API changes: - [x] (If breaking change) tt_metal approved PR pointing to this branch: tenstorrent/tt-metal#14752 - [x] (If breaking change) tt_debuda approved PR pointing to this branch: tenstorrent/tt-debuda#158
broskoTT
force-pushed
the
brosko/change_name_to_cluster
branch
from
d041ac4
to
e46bf90
Compare
ayerofieiev-tt
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #13948
What's changed
Related UMD PR: tenstorrent/tt-umd#265
Changed naming
tt_device.h -> cluster.h
tt_SiliconDriver -> tt::umd::Cluster
Checklist