Rename architecture_implementation to TTDevice #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
joelsmithTT and
pjanevskiTT
and removed request for
joelsmithTT
Open
broskoTT
force-pushed
the
brosko/tt_device
branch
from
4fa73fb
to
6d2bde9
Compare
joelsmithTT
approved these changes
Oct 14, 2024
| @@ -585,7 +585,7 @@ class tt_device | |||
| std::unordered_map<chip_id_t, tt_SocDescriptor> soc_descriptor_per_chip = {}; | |||
| }; | |||
|
|
|||
| #include "device/architecture_implementation.h" | |||
| #include "device/tt_device/tt_device.h" | |||
There was a problem hiding this comment.
device/tt_device.h and device/tt_device/tt_device.h is confusing.
There was a problem hiding this comment.
Yes, exactly. I've left a comment in the PR because of that, to wait for tt_device rename to cluster.h first maybe. Even tt_device and TTDevice is confusing. @vtangTT removed this class previously specifically to remove confusion.
I'll leave this comment open until this is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first step related to #98
For more information consult https://docs.google.com/drawings/d/1-m1azdsBqMA0A6ATYRMfkhyeuOJuGCEI62N5a96LXj0/edit
This change just renames and moves files, without any functional changes -> for ease of review.
The following change will implement further changes to set TTDevice own PCIDevice, rather than other way around.
Not sure though if I should wait for original tt_device.h to be renamed first to something else (cluster.h), not to add confusion with this rename.