Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTDevice class #98

Open
broskoTT opened this issue Oct 2, 2024 · 0 comments · May be fixed by #145
Open

TTDevice class #98

broskoTT opened this issue Oct 2, 2024 · 0 comments · May be fixed by #145
Assignees
@broskoTT
Labels
api redesign Related to the ongoing push for redesigning UMDs api P0 Critical issues, needs immediate attention

Comments

@broskoTT
Copy link
Contributor

broskoTT commented Oct 2, 2024

According to https://docs.google.com/drawings/d/1-m1azdsBqMA0A6ATYRMfkhyeuOJuGCEI62N5a96LXj0/edit?usp=sharing
Make TTDevice abstract class which holds unique_ptr. This is then specialized per Arch , rather than holding architecture_implementation per arch. Also move functions from PCIDevice for what makes sense to be in TTDevice.
One potential implementation can be found here https://github.com/tenstorrent/tt-umd/blob/brosko/new_api_experiment/new_device/tt_device.h
@broskoTT broskoTT added the api redesign Related to the ongoing push for redesigning UMDs api label Oct 2, 2024
This was referenced Oct 10, 2024
Open
Open
@broskoTT broskoTT linked a pull request Oct 10, 2024 that will close this issue
Rename architecture_implementation to TTDevice #145
Open
@pjanevskiTT pjanevskiTT added the P0 Critical issues, needs immediate attention label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broskoTT broskoTT

Labels
api redesign Related to the ongoing push for redesigning UMDs api P0 Critical issues, needs immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename architecture_implementation to TTDevice tenstorrent/tt-umd
2 participants
@broskoTT @pjanevskiTT