Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7817: Add Slack notification on failure for Performance Models #8411

Merged
merged 1 commit into from
May 14, 2024
Merged

#7817: Add Slack notification on failure for Performance Models #8411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/actions/slack-report/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: "Report Workflow Status to Slack"
description: "Report the workflow status to Slack to help identify breakages faster."
inputs:
owner:
description: "The Slack ID of the person to be tagged."
default: "U014XCQ9CF8" # @Raymond Kim
tt-rkim marked this conversation as resolved.
Show resolved Hide resolved
slack_webhook_url:
required: true
runs:
using: "composite"
steps:
- name: Report Github Pipeline Status Slack Action
uses: slackapi/[email protected]
with:
payload: |
{
"text": "just so you know `${{ github.event.sender.login }}` broke ${{ github.workflow }} with https://github.com/tenstorrent/tt-metal/commit/${{ github.sha }}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if the ${{ github.event.sender.login }} was part of github link as they are not being highlighted as an object or figure out a way of how to tag a person in Slack.

"owner": "${{ inputs.owner }}"
}
env:
SLACK_WEBHOOK_URL: ${{ inputs.slack_webhook_url }}
5 changes: 5 additions & 0 deletions .github/workflows/perf-models.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,15 @@ jobs:
run: tar -xvf ttm_${{ matrix.runner-info.arch }}.tar
- uses: ./.github/actions/install-python-deps
- name: Run performance regressions
id: performance_tests
timeout-minutes: 60
run: |
source ${{ github.workspace }}/python_env/bin/activate
./tests/scripts/run_tests.sh --tt-arch $ARCH_NAME --pipeline-type ${{ matrix.model-type }}_models_performance_${{ matrix.runner-info.machine-type }}
- uses: ./.github/actions/slack-report
if: ${{ steps.performance_tests.outcome != 'success' }}
with:
slack_webhook_url: ${{ secrets.SLACK_WEBHOOK_URL }}
- name: Check perf report exists
id: check-perf-report
if: ${{ !cancelled() }}
Expand Down
Loading