Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7817: Add Slack notification on failure for Performance Models #8411

Merged
merged 1 commit into from
May 14, 2024

Conversation

dimitri-tenstorrent
Copy link
Contributor

@dimitri-tenstorrent dimitri-tenstorrent commented May 13, 2024

  • Create a new Github action that allows to send a slack notificaton
  • Add reporting to Nightly pipelines
  • Create a concept of owner that can be specified and for now use @tt-rkim as a default maintainer

This creates a structure for adding a lot more notifications and identifying specific owners for different sections of the pipelines.

Follow up: #8304

@dimitri-tenstorrent dimitri-tenstorrent force-pushed the dimitri/7817-slack-notifications branch 2 times, most recently from e0b224a to 8e0c891 Compare May 13, 2024 21:08
with:
payload: |
{
"text": "just so you know `${{ github.event.sender.login }}` broke ${{ github.workflow }} with https://github.com/tenstorrent/tt-metal/commit/${{ github.sha }}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if the ${{ github.event.sender.login }} was part of github link as they are not being highlighted as an object or figure out a way of how to tag a person in Slack.

 - Slack notifications
 - Add reporting to Nightly pipelines
 - Use owner as a separate field
@dimitri-tenstorrent dimitri-tenstorrent merged commit c3bf878 into main May 14, 2024
5 checks passed
@dimitri-tenstorrent dimitri-tenstorrent deleted the dimitri/7817-slack-notifications branch May 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants