-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7817: Add Slack notification on failure for Performance Models #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-tenstorrent
changed the title
#7817: Add Slack notification on failure
#7817: Add Slack notification on failure for Performance Models
May 13, 2024
dimitri-tenstorrent
force-pushed
the
dimitri/7817-slack-notifications
branch
from
May 13, 2024 19:49
28be2ed
to
c08baf3
Compare
TT-billteng
reviewed
May 13, 2024
TT-billteng
approved these changes
May 13, 2024
dimitri-tenstorrent
force-pushed
the
dimitri/7817-slack-notifications
branch
2 times, most recently
from
May 13, 2024 21:08
e0b224a
to
8e0c891
Compare
with: | ||
payload: | | ||
{ | ||
"text": "just so you know `${{ github.event.sender.login }}` broke ${{ github.workflow }} with https://github.com/tenstorrent/tt-metal/commit/${{ github.sha }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if the ${{ github.event.sender.login }}
was part of github link as they are not being highlighted as an object or figure out a way of how to tag a person in Slack.
dimitri-tenstorrent
force-pushed
the
dimitri/7817-slack-notifications
branch
from
May 14, 2024 16:10
8e0c891
to
7255dc1
Compare
tt-rkim
approved these changes
May 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a structure for adding a lot more notifications and identifying specific owners for different sections of the pipelines.
Follow up: #8304