Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup some error messages #4209

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Fixup some error messages #4209

merged 4 commits into from
Dec 6, 2023

Commits on Dec 6, 2023

  1. #0: Reduce spew when logging not done cores

    @pgkeller
    pgkeller committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    18462be View commit details
    Browse the repository at this point in the history

  2. #4197: Improve thorw/assert/fatal message formatting 

    Use log_fatal (reintroduced) to print both "fatal" and arguments of failure
strings.
    @pgkeller
    pgkeller committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e57c66c View commit details
    Browse the repository at this point in the history

  3. #4197: Make watcher error messages less terse

    @pgkeller
    pgkeller committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f708f89 View commit details
    Browse the repository at this point in the history

  4. #4197: Fix tests that use assert instead of throw 

    Assert can go away w/ release builds leading to unused var warnings.
    @pgkeller
    pgkeller committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1bcc573 View commit details
    Browse the repository at this point in the history