Fixup some error messages #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgkeller
force-pushed
the
pkeller/misc
branch
from
43bd861
to
19a5cbb
Compare
TT-billteng
approved these changes
Dec 6, 2023
Use log_fatal (reintroduced) to print both "fatal" and arguments of failure strings.
Assert can go away w/ release builds leading to unused var warnings.
pgkeller
force-pushed
the
pkeller/misc
branch
from
19a5cbb
to
1bcc573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT_ASSERT/TT_THROW/TT_FATAL were hard to read after the migration away from log_fatal
Watcher strings are now less terse