Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core and add durations-as-seconds metric option #498

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Update core and add durations-as-seconds metric option #498

merged 2 commits into from
Apr 1, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 1, 2024 •
edited
Loading

What was changed

  • Update Core
  • Made durations from core still show as milliseconds to users
  • Add durations_as_seconds boolean option to OTel and Prom configs

This is only half of #493 and doesn't even include tests for the second bullet here. There will be another PR incoming which will add the ability to accept durations and tests.

@cretz cretz requested a review from a team as a code owner April 1, 2024 19:29
@cretz cretz mentioned this pull request Apr 1, 2024
Closed
@cretz cretz merged commit 13d18ca into temporalio:main Apr 1, 2024
11 checks passed
@cretz cretz deleted the metric-seconds-config branch April 1, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @Sushisource