Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support metric option for using seconds (and other recent core metric changes) #493

Closed
cretz opened this issue Mar 26, 2024 · 1 comment · Fixed by #508
Closed

[Feature Request] Support metric option for using seconds (and other recent core metric changes) #493

cretz opened this issue Mar 26, 2024 · 1 comment · Fixed by #508
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Mar 26, 2024

Describe the solution you'd like

Need to at least expose use_seconds_for_duration option on Prometheus metrics from temporalio/sdk-core#706, may also have to update other things due to changes made by that PR.
@cretz cretz added the enhancement New feature or request label Mar 26, 2024
@cretz cretz mentioned this issue Apr 1, 2024
Merged
@cretz
Copy link
Member Author

cretz commented Apr 1, 2024

Half of this was done at #498, still need:

  • Tests for duration values as seconds
  • Ability to set duration values in custom metrics

cretz added a commit to cretz/temporal-sdk-python that referenced this issue Apr 12, 2024
@cretz
Support float and duration metrics
8366387 
Fixes temporalio#493
@cretz cretz mentioned this issue Apr 12, 2024
Merged
cretz added a commit that referenced this issue Apr 18, 2024
@cretz
Support float and duration metrics (#508)
50c2033 
Fixes #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support float and duration metrics cretz/temporal-sdk-python
1 participant
@cretz