Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken if-else logic in JSON schema #572

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

nickdnk
Copy link
Contributor

@nickdnk nickdnk commented Oct 26, 2024

Reason for This PR

There's a problem with the if-else logic in the schema here.

Description of Changes

I replaced if-else with a oneOf for a valid combination of options. I have tested this locally so it should be the last PR for this repo.
Also, address is not required. I looked at the driver and it defaults to localhost:7233. I changed it only for consistency with the prometheus package; I'm aware localhost and 127.0.0.1 is the same.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review October 26, 2024 10:10
@rustatian rustatian self-assigned this Oct 26, 2024
@rustatian rustatian added the A-docs Area: documentation label Oct 26, 2024
@rustatian rustatian merged commit 1ea74cc into temporalio:master Oct 26, 2024
7 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.06%. Comparing base (9e19b6e) to head (c5c2e9a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files          14       14           
  Lines         936      936           
=======================================
  Hits          375      375           
  Misses        518      518           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants