[#572]: chore: Fix broken if-else logic in JSON schema

temporalio · Oct 26, 2024 · 1ea74cc · 1ea74cc
2 parents 40b5e1c + c5c2e9a
commit 1ea74cc
Showing 1 changed file with 26 additions and 42 deletions.
diff --git a/schema.json b/schema.json
@@ -5,14 +5,11 @@
   "type": "object",
   "title": "roadrunner-temporal",
   "additionalProperties": false,
-  "required": [
-    "address"
-  ],
   "properties": {
     "address": {
-      "description": "Address of the Temporal server.",
+      "description": "Address of the Temporal server. Defaults to localhost:7233 if not provided.",
       "type": "string",
-      "default": "127.0.0.1:7233",
+      "default": "localhost:7233",
       "minLength": 1
     },
     "cache_size": {
@@ -26,53 +23,40 @@
       "default": "default"
     },
     "metrics": {
-      "type": "object",
-      "description": "Temporal metrics.",
-      "required": [
-        "driver"
-      ],
-      "properties": {
-        "driver": {
-          "description": "Metrics driver to use.",
-          "type": "string",
-          "enum": [
-            "prometheus",
-            "statsd"
-          ],
-          "default": "prometheus"
-        }
-      },
-      "if": {
-        "properties": {
-          "driver": {
-            "const": "prometheus"
-          }
-        }
-      },
-      "then": {
-        "properties": {
-          "prometheus": {
-            "$ref": "#/$defs/Prometheus"
-          }
-        }
-      },
-      "else": {
-        "if": {
+      "oneOf": [
+        {
+          "type": "object",
+          "additionalProperties": false,
           "properties": {
             "driver": {
-              "const": "statsd"
+              "description": "The Prometheus driver.",
+              "type": "string",
+              "enum": [
+                "prometheus"
+              ]
+            },
+            "prometheus": {
+              "$ref": "#/$defs/Prometheus"
             }
           }
         },
-        "then": {
+        {
+          "type": "object",
+          "additionalProperties": false,
           "properties": {
+            "driver": {
+              "description": "The Statsd driver.",
+              "type": "string",
+              "enum": [
+                "statsd"
+              ]
+            },
             "statsd": {
               "$ref": "#/$defs/Statsd"
             }
           }
-        },
-        "else": false
-      }
+        }
+      ]
     },
     "activities": {
       "$ref": "https://raw.githubusercontent.com/roadrunner-server/pool/refs/heads/master/schema.json"