Use the new temporalproto JSON APIs #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
commented
Nov 28, 2023
.github/workflows/ci.yaml
Outdated
| @@ -141,7 +141,7 @@ jobs: | |||
| # TODO: Find some way to automatically upgrade to "latest" | |||
| with: | |||
| do-push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} | |||
| go-repo-ref: 'f9d73bfdf7c8d3ec0311306140fbfafa7fb6f9cf' | |||
| go-repo-ref: '8f2a3c8f967a5898f45df92f6bc42196e4702a2d' | |||
There was a problem hiding this comment.
This is the first version of the SDK that uses the new APIs
These offer better performance than the previous versions.
tdeebswihart
force-pushed
the
tdeebswihart/use-new-temporalproto-api
branch
from
bde2815
to
8d9d173
Compare
This was referenced Nov 28, 2023
cretz
approved these changes
Nov 29, 2023
cretz
reviewed
Nov 29, 2023
| @@ -9,7 +9,7 @@ require ( | |||
| github.com/temporalio/features/features v1.0.0 | |||
| github.com/temporalio/features/harness/go v1.0.0 | |||
| github.com/urfave/cli/v2 v2.25.7 | |||
| go.temporal.io/sdk v1.25.2-0.20231121222453-f9d73bfdf7c8 | |||
| go.temporal.io/sdk v1.25.2-0.20231129163633-77626eee3015 | |||
There was a problem hiding this comment.
Not the biggest fan of using untagged SDKs in the features repo main branch. But I guess we had already done it.
There was a problem hiding this comment.
Yeah. As we discussed (this is for public record, hello!) I'm going to merge from now to keep usage simple since this is a breaking change that hit both the SDK and the Server, but will do so next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I bumped the version of the SDK and API to make use of our new temporalproto APIs
Why?
We made a breaking change in the API