Re-enable shorthand HTTP API #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Nov 29, 2023
bergundy
reviewed
Nov 29, 2023
service/frontend/http_api_server.go
Outdated
There was a problem hiding this comment.
nit: I still see a couple of references to gogo in comments in this file.
There was a problem hiding this comment.
I don't have enough context to know whether the claims there are still true. @cretz, as the author, do the claims about gogo-status-compatible but not grpc-status-compatible in errorHandler still hold?
bergundy
reviewed
Nov 29, 2023
bergundy
approved these changes
Nov 29, 2023
I also added tests for all four mime-types we support to ensure we _actually_ support each of them.
tdeebswihart
force-pushed
the
tdeebswihart/shorthand-http-api
branch
from
9bcdbdb
to
e16d1be
Compare
|
I'm setting this to automerge when tests pass to unblock other work that's hurt by the api-go changes. This should be the last time I break things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This re-enables the shorthand payload format for our HTTP API.
Why?
This is a business requirement for our HTTP API.
How did you test it?
I updated our HTTP API tests to test all four mimetypes we support
Potential risks
None
Is hotfix candidate?
No.