Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that remote mounts work with --replace (and other fixes) #3500

Merged
merged 8 commits into from
Feb 4, 2024

Commits on Feb 2, 2024

  1. Add context parameter to agent State's SetManager call.

    This is necessary to make an improvement in the pro-agent's version of
    the call, where the context will be needed.
    
    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b87b536 View commit details
    Browse the repository at this point in the history
  2. Disable replaced app-container during intercept instead of removing it.

    This commit changes the code that enables the `--replace` flag, so that
    the app-container is kept in place, but with an image that will just
    sleep infinitely and has no probes. The image is needed so that its
    mounts and environment is visible to the traffic-agent container
    generator.
    
    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    4ed7c63 View commit details
    Browse the repository at this point in the history
  3. The --replace flag no longer require subsequent intercepts to replace.

    A `telepresence intercept --replace` will no longer switch the mode of
    the intercepted workload, forcing all subsequent intercepts on that
    workload to use `--replace` until the agent is uninstalled. Instead,
    `--replace` can be used interchangeably just like any other intercept
    flag.
    
    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3a532f4 View commit details
    Browse the repository at this point in the history
  4. Add more integration tests for the --replace flag.

    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    bee8231 View commit details
    Browse the repository at this point in the history
  5. Use "app" selector consistently in integration tests.

    Also improves reliability of CapturePodLogs.
    
    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8d383b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Deactivate agents that are about to die.

    When a change is made to an entry in the `telepresence-agents`
    comfigmap, then the pods of the targeted workflow will be restarted.
    It is then of some importance that they no longer participate as
    agents for intercepts.
    
    This commit ensures that such pods become inactive, which means that
    they will no longer be able to modify intercepts with a call to
    `ReviewIntercept`.
    
    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    c542ab6 View commit details
    Browse the repository at this point in the history
  2. Upgrade go-fuseftp to version 0.4.4

    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    e2a0c0b View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Disable InterceptFlag test suite on darwin due to macFUSE.

    Signed-off-by: Thomas Hallgren <[email protected]>
    thallgren committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    5497d53 View commit details
    Browse the repository at this point in the history