Ensure that remote mounts work with --replace (and other fixes) #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make an improvement in the pro-agent's version of the call, where the context will be needed. Signed-off-by: Thomas Hallgren <[email protected]>
This commit changes the code that enables the `--replace` flag, so that the app-container is kept in place, but with an image that will just sleep infinitely and has no probes. The image is needed so that its mounts and environment is visible to the traffic-agent container generator. Signed-off-by: Thomas Hallgren <[email protected]>
A `telepresence intercept --replace` will no longer switch the mode of the intercepted workload, forcing all subsequent intercepts on that workload to use `--replace` until the agent is uninstalled. Instead, `--replace` can be used interchangeably just like any other intercept flag. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
6 tasks
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/replace-fix
branch
from
c6c0d3d
to
6713cd8
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Also improves reliability of CapturePodLogs. Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/replace-fix
branch
from
6713cd8
to
8d383b4
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
When a change is made to an entry in the `telepresence-agents` comfigmap, then the pods of the targeted workflow will be restarted. It is then of some importance that they no longer participate as agents for intercepts. This commit ensures that such pods become inactive, which means that they will no longer be able to modify intercepts with a call to `ReviewIntercept`. Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/replace-fix
branch
from
860afff
to
e2a0c0b
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some parts of the implementation for the
--replaceflag. In particular:--replacewill no longer affect intercepts on other containers.--replaceoption can be used interchangeably, without uninstalling the agent.