-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use teleport packages for code-embed and date-time primitive #810
base: development
Are you sure you want to change the base?
Changes from all commits
7680a14
16e2a2d
7b359f7
b144992
212a66a
41c93cb
551de2f
3793df7
0f6c9d8
2ca713a
ebfbdda
c2cd672
76afae9
8719205
b025488
7b8416c
feb9736
9ea38a8
375ce04
ccc3433
46aad3c
1ada61e
4615828
be1bf9c
0cc2dc7
9638398
85a2947
ad6dbbb
ed116ba
7b608c2
4985000
e78b7b1
618b405
bb34bb3
3651be4
26e3496
4bc76ab
efefe98
77c0c39
6706d92
14474a5
1d67719
215d49b
e8e08fe
3429ec8
6344b93
35cf758
68c42a8
da8e29d
df1fd49
b50fef0
5e89aee
61ebde2
ad369c2
7c95340
59c9390
1826e45
fefe05d
1ec82a1
4a28f5f
eef5f37
776fa2b
6522eae
dc49e98
62f358a
aef4f43
6950c36
ef08735
0f348a1
da7d357
feefc61
1eaf52c
709e0e8
46bbbd4
fe9a891
6c93c42
9c7292b
2b2ac3f
ca0270f
3c8a364
183a537
5e971d6
58e3917
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,10 +16,24 @@ export const PlainHTMLMapping: Mapping = { | |
dependency: { | ||
type: 'package', | ||
path: 'dangerous-html', | ||
version: '0.1.12', | ||
version: '1.0.0', | ||
meta: { | ||
importJustPath: true, | ||
importAlias: 'https://unpkg.com/[email protected]/dist/default/lib.umd.js', | ||
importAlias: | ||
'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js', | ||
}, | ||
}, | ||
}, | ||
'date-time-node': { | ||
elementType: 'date-time-primitive', | ||
dependency: { | ||
type: 'package', | ||
version: '1.0.0', | ||
path: 'date-time-primitive', | ||
meta: { | ||
importJustPath: true, | ||
importAlias: | ||
'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ionutpasca we can use single repo to maintain all 3 frameworks. As vite can build all three at the same time. As the changes always need to be in sync with all the three flavours. That makes it less confusing while maintaining too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, I spoke with vladut. We can keep them seperately. But, let's map these URL's to independent umd builds. Instead of loading all of them 👍 |
||
}, | ||
}, | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we need to improve this, or else if we are using just
dangerous-html
. It installs thedate-time-primitive
too even if we are not using. Since these areumd
builds. The bundlers can't tree shake them