Use teleport packages for code-embed and date-time primitive #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility for each page to define resources for static paths and props
Add support for fetch requests and nextjs static paths and props
…erators into development
* Add support for pagination on static paths/props * Small changes in cms project uidl --------- Co-authored-by: Ionut Pasca <[email protected]>
Add CMS list+item nodes support
Add support for CMS list and CMS item inside nextjs generators
* Changes required for contentful support * Small changes * Add possibility to use mapper functions for cms list/items & initialProps (#767) Co-authored-by: Ionut Pasca <[email protected]> --------- Co-authored-by: Ionut Pasca <[email protected]>
* Progress so far * Progress so far * aRemove type cast that was unnecesarry * A better example * Feat/contentful richtext (#768) * Support for dynamic attributes from ctx * Test and fix for contentful richtext node * Remove console.log * We dont use package.lock * Bring back standalone --------- Co-authored-by: Eliza Nitoi <[email protected]> Co-authored-by: Ionut Pasca <[email protected]>
* Allow static values on component seo and meta tags * Small change --------- Co-authored-by: Ionut Pasca <[email protected]>
* Subselector support for classes * Add explanation for & * Support states and MQs for subselector classes as well
…gs (#795) * normalization of UIDL and new changes for resource mappings * Add support for cms-list using api and plugins * Combine next and react fetch plugins into one * Allow trace for logs * Ability to handle cms-item and make the request post only when needed * Add params only when needed in next apis * Make mappers configurable and fix all the tests
Co-authored-by: Eliza N <[email protected]>
* (feat): Add response type for resources * Add explanation for AST resposnse
Co-authored-by: Ionut Pasca <[email protected]>
Co-authored-by: Ionut Pasca <[email protected]>
| @@ -32,7 +33,7 @@ export const PlainHTMLMapping: Mapping = { | |||
| meta: { | |||
| importJustPath: true, | |||
| importAlias: | |||
| 'https://github.com/teleporthq/date-time-primitive/blob/main/dist/default/lib.umd.js', | |||
| 'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js', | |||
There was a problem hiding this comment.
@ionutpasca we can use single repo to maintain all 3 frameworks. As vite can build all three at the same time. As the changes always need to be in sync with all the three flavours. That makes it less confusing while maintaining too.
There was a problem hiding this comment.
ok, I spoke with vladut. We can keep them seperately. But, let's map these URL's to independent umd builds. Instead of loading all of them 👍
| meta: { | ||
| importJustPath: true, | ||
| importAlias: 'https://unpkg.com/[email protected]/dist/default/lib.umd.js', | ||
| importAlias: | ||
| 'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js', |
There was a problem hiding this comment.
And we need to improve this, or else if we are using just dangerous-html. It installs the date-time-primitive too even if we are not using. Since these are umd builds. The bundlers can't tree shake them
|
I will take care of this @ionutpasca. I would like to change the build system a little for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.