-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the design of the checks and phases in HTML report plugin #3095
Conversation
2ec0043
to
c5f29da
Compare
b0ed4bd
to
bc7c7ae
Compare
bc7c7ae
to
d054f5c
Compare
The #3106 is the prerequisite for this PR (see "Blocked by" section in my first comment on this PR. I will rebase the changes on top of #3106. The same applies for #3107. |
d054f5c
to
3b064df
Compare
Just an update of screenshots. The #3106 is still a prerequisite. My testing data:
|
71b90b7
to
b7496cf
Compare
b7496cf
to
5647df5
Compare
ba70304
to
bfb1c23
Compare
bfb1c23
to
3f203e9
Compare
I think I should maybe add some tests which will fake the subresults data and check the html result. What do you think? |
Good idea, deserves a test. |
53d80f9
to
dedb616
Compare
I’ve added the tests. This PR should be ready to merge once the tests pass. |
dedb616
to
ef7c14e
Compare
Fix the colspan of the main table, add a new column "Actions" into the table and add possibility to show/hide the checks and subresults row for each result. Also, show all the checks in the subresults table. Do not hide them by default as it's done with general result checks.
ef7c14e
to
634d838
Compare
Unrelated failures, merging. |
I tried to fix the colspan of the main table, added a new column "Actions" into the table, and added the possibility to show/hide the checks and subresults row for each result using the toggle buttons.
The #3094 is a prerequisite to test the code in this PR. To generate the subresults in the attached screenshots, I have for now faked the
subresult
data in theplans/example/execute/results.yaml
as following:Related to:
Blocked by:
TODOs:
Pull Request Checklist
Example screenshots: